Make saving 'last' checkpoint as symbolic link opt-in #19191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
awaelchli
added
feature
awaelchli
requested review from
carmocca,
justusschock,
Borda and
williamFalcon
as code owners
awaelchli
added
the
fun
carmocca
approved these changes
Dec 21, 2023
Borda
approved these changes
Dec 21, 2023
|
ok, seems this is the victim of the broken master, with frozen requirements it passes but not with all the latest... UPDATE: seemed that the last check was missing PL test stunning https://github.com/Lightning-AI/pytorch-lightning/actions/runs/7281654535 but how Probot let it go? @carmocca |
This was referenced Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Several complaints from users have made it clear that the feature to save the 'last.ckpt' file as symbolic link is not wanted. In this PR, I'm reverting the decision to make a symbolic link by default, and make the feature opt-in instead.
This is a breaking change, tell me more about it :))
Fixes #19189
Fixes #19189
Fixes #19107
This partially reverts #18748
📚 Documentation preview 📚: https://pytorch-lightning--19191.org.readthedocs.build/en/19191/
cc @Borda @justusschock @carmocca @awaelchli