Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in MeanAveragePrecision.coco_to_tm #2588

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jun 4, 2024

What does this PR do?

Fixes #2587

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2588.org.readthedocs.build/en/2588/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jun 4, 2024
@SkafteNicki SkafteNicki added this to the v1.3.x milestone Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36%. Comparing base (1b77689) to head (d284694).
Report is 96 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1b77689) and HEAD (d284694). Click for more details.

HEAD has 80 uploads less than BASE
Flag BASE (1b77689) HEAD (d284694)
Windows 6 3
python3.8 6 3
cpu 40 20
torch1.13.1+cpu 6 3
torch1.11.0+cpu 2 1
Linux 24 12
python3.9 16 8
torch1.12.1+cpu 2 1
torch1.10.2+cpu 2 1
torch2.0.1+cpu 6 3
python3.10 10 5
torch2.3.0+cpu 6 3
python3.11 8 4
macOS 10 5
torch2.0.1 4 2
torch1.13.1 2 1
torch2.2.2+cpu 4 2
torch2.1.2+cpu 2 1
torch2.3.0 2 1
torch2.2.2 2 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2588     +/-   ##
========================================
- Coverage      69%     36%    -33%     
========================================
  Files         314     314             
  Lines       17696   17700      +4     
========================================
- Hits        12198    6347   -5851     
- Misses       5498   11353   +5855     

@mergify mergify bot added the ready label Jun 4, 2024
@stancld stancld enabled auto-merge (squash) June 4, 2024 20:37
@stancld stancld merged commit 8172c58 into master Jun 5, 2024
61 checks passed
@stancld stancld deleted the bugfix/map_tm_to_coco branch June 5, 2024 08:25
Borda pushed a commit that referenced this pull request Aug 2, 2024
* fix implementation

* tests

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit 8172c58)
Borda pushed a commit that referenced this pull request Aug 2, 2024
* fix implementation

* tests

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
(cherry picked from commit 8172c58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready topic: Detect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeanAveragePrecision.tm_to_coco example fails with IndexError: list index out of range
3 participants