Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor StrEnum.from_str #102

Merged
merged 12 commits into from
Feb 14, 2023
Merged

Refactor StrEnum.from_str #102

merged 12 commits into from
Feb 14, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 7, 2023

Review of #99

@carmocca carmocca self-assigned this Feb 7, 2023
@carmocca @Borda
Update src/lightning_utilities/core/enums.py
f6cfd89 
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
@Borda Borda force-pushed the main branch 3 times, most recently from 656bdff to 11958a8 Compare February 8, 2023 04:13
@carmocca carmocca requested a review from Borda February 9, 2023 20:21
@Borda Borda changed the title Refactor from_str Refactor StrEnum.from_str Feb 14, 2023
@Borda Borda merged commit 78eb098 into main Feb 14, 2023
@Borda Borda deleted the refactor/from-str branch February 14, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@akihironitta akihironitta Awaiting requested review from akihironitta

Assignees

@carmocca carmocca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carmocca @Borda