chore: compressed-token token extension compat #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananas-block
requested review from
SwenSchaeferjohann and
vadorovsky
as code owners
ananas-block
force-pushed
the
jorrit/chore-compressed-token-token-extension-compat
branch
from
e947968
to
1045485
Compare
Comment on lines
9
to
10
| 'can have one token pool. When a token is compressed the compressed', | ||
| 'tokens are transferrred to the token pool.', |
There was a problem hiding this comment.
imo it's easier to understand if we say something like this:
Suggested change
| 'can have one token pool. When a token is compressed the compressed', | |
| 'tokens are transferrred to the token pool.', | |
| 'can have one token pool. When a token is compressed the SPL', | |
| 'tokens are transferrred to the token pool, and their compressed equivalent is minted into a Merkle tree.', |
| @@ -51,7 +50,11 @@ export type LightCompressedToken = { | |||
| 'Mints tokens from an spl token mint to a list of compressed accounts.', | |||
| 'Minted tokens are transferred to a pool account owned by the compressed', | |||
| 'token program. The instruction creates one compressed output account for', | |||
| 'every amount and pubkey input pair one output compressed account.', | |||
| 'every amount and pubkey input pair one output compressed account. A', | |||
There was a problem hiding this comment.
duplicate 'one output compressed account'
Comment on lines
168
to
169
| 'decompressed. In one transaction only compression or decompression is', | ||
| 'possible. Lamports can be transferred along side tokens. If output token', |
There was a problem hiding this comment.
Suggested change
| 'decompressed. In one transaction only compression or decompression is', | |
| 'possible. Lamports can be transferred along side tokens. If output token', | |
| 'decompressed. In one transaction only compression or decompression is', | |
| 'possible. Lamports can be transferred alongside tokens. If output token', |
| 'decompressed. In one transaction only compression or decompression is', | ||
| 'possible. Lamports can be transferred along side tokens. If output token', | ||
| 'accounts specify less lamports than inputs the remaining lamports are', | ||
| 'transferred to an output compressed account. Signer must owner or', |
There was a problem hiding this comment.
Suggested change
| 'transferred to an output compressed account. Signer must owner or', | |
| 'transferred to an output compressed account. Signer must be owner or', |
| @@ -317,6 +338,10 @@ export type LightCompressedToken = { | |||
| }, | |||
| { | |||
| name: 'revoke'; | |||
| docs: [ | |||
| 'Revokes a delegation. The instruction merges all inptus into one output', | |||
There was a problem hiding this comment.
Suggested change
| 'Revokes a delegation. The instruction merges all inptus into one output', | |
| 'Revokes a delegation. The instruction merges all inputs into one output', |
Comment on lines
+1915
to
+1916
| 'are included in the token data hash, which is a public input to the', | ||
| 'validity proof.', |
Comment on lines
+1842
to
+1843
| 'are included in the token data hash, which is a public input to the', | ||
| 'validity proof.', |
SwenSchaeferjohann
approved these changes
Jul 21, 2024
ananas-block
deleted the
jorrit/chore-compressed-token-token-extension-compat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Option<Vec<u8>>to:TokenDataPackedTokenTransferOutputDataInputTokenDataWithContextNoneif set instructions panic with unimplementedNote:
TokenDataare breaking changes for photoncompressed-token.jsare disabled