refactor: forester: switch logging from log to tracing
#1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the `log` crate with `tracing` for improved structured logging. Switched various log levels, such as from `info` to `debug`, and updated macros accordingly. Adjusted dependencies in `Cargo.toml` and removed `log` crate.
sergeytimoshin
force-pushed
the
sergey/forester-cleanup-logs
branch
from
46bd168
to
34142d6
Compare
ananas-block
reviewed
Sep 2, 2024
| @@ -55,7 +55,7 @@ pub async fn run_queue_info( | |||
| QUEUE_LENGTH | |||
| .with_label_values(&[&*queue_type.to_string(), &tree_data.merkle_tree.to_string()]) | |||
| .set(queue_length as i64); | |||
| info!( | |||
| println!( | |||
There was a problem hiding this comment.
println! instead of debug on purpose?
There was a problem hiding this comment.
Yes. It's not a debug printout, its output for the user.
ananas-block
reviewed
Sep 2, 2024
ananas-block
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logcrate withtracingfor improved structured logging.Cargo.tomland removedlogcrate.