-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prover.ts: decouple prover.ts from zk.js #169
prover.ts: decouple prover.ts from zk.js #169
Conversation
Thanks! I noticed that it is not used in zk.js yet (it probably wasn't used in the prior pr either). |
); | ||
}); | ||
|
||
it("Test Generic Self-contained Prover for VerifierZero", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding tests you could add a couple more standard tests:
- failing
- run full prove two times and receive the same public inputs as output (the proof will be different ofc because it is using different randomness)
snarkjs's process does not terminate automatically can you add the following to terminate it?
|
}); | ||
|
||
after(async () => { | ||
globalThis.curve_bn128.terminate(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intuition was to put this into the prove method.
Do you see tradeoff putting it in there?
@sergeytimoshin The test failure might not be related to your changes, since it is complaining about an account with insufficient rent. |
Draft based on #126