feat: protocol config #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananas-block
force-pushed
the
jorrit/feat-protocol-config
branch
3 times, most recently
from
8fb5872
to
8d8dc00
Compare
vadorovsky
reviewed
Jul 26, 2024
forester/src/rollover/operations.rs
Outdated
| create_rollover_address_merkle_tree_instruction, create_rollover_state_merkle_tree_instruction, | ||
| CreateRolloverMerkleTreeInstructionInputs, | ||
| }; | ||
| // use light_registry::sdk::{ |
There was a problem hiding this comment.
Can we just remove these imports?
| /// Anyone can create new trees just the fees cannot be set arbitrarily. | ||
| #[account(mut)] | ||
| pub authority: Signer<'info>, | ||
| /// CHECK: |
There was a problem hiding this comment.
Could we at least add something like
Suggested change
| /// CHECK: | |
| /// CHECK: Is checked in the account-compression program during CPI. |
in all fields where Anchor requires CHECK docstrings? I know it's obvious for us, but some context would be helpful (for auditors as well).
|
|
||
| #[derive(Accounts)] | ||
| pub struct NullifyLeaves<'info> { | ||
| /// CHECK: |
Comment on lines
21
to
22
| #[account(mut)] | ||
| #[account(seeds = [CPI_AUTHORITY_PDA_SEED], bump)] |
There was a problem hiding this comment.
First of all, does CPI authority need to be mutable here?
I don't think it should be necessary, but if I'm missing something and it needs to be mutable, could we merge these into one #[account] attribute?
Suggested change
| #[account(mut)] | |
| #[account(seeds = [CPI_AUTHORITY_PDA_SEED], bump)] | |
| #[account(mut, seeds = [CPI_AUTHORITY_PDA_SEED], bump)] |
| pub account_compression_program: Program<'info, AccountCompression>, | ||
| /// CHECK: when emitting event. | ||
| pub log_wrapper: UncheckedAccount<'info>, | ||
| /// CHECK: in account compression program |
There was a problem hiding this comment.
or, well, even such comment is sufficient, I would be fine with copying it to the empty CHECK: fields
|
|
||
| #[derive(Accounts)] | ||
| pub struct RolloverMerkleTreeAndQueue<'info> { | ||
| /// CHECK: |
ananas-block
force-pushed
the
jorrit/feat-protocol-config
branch
from
8d8dc00
to
846372b
Compare
refactor: registry program add forester selection and contention fix rollover test, regenerate idl
ananas-block
force-pushed
the
jorrit/feat-protocol-config
branch
from
846372b
to
6b91696
Compare
vadorovsky
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conceptual Changes:
forester_accountsChanges:
Note:
msg!prints in registry program for now for debugging