Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build installer for Windows #40

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Build installer for Windows #40

merged 2 commits into from
Feb 23, 2020

Conversation

Lihis
Copy link
Owner

@Lihis Lihis commented Feb 8, 2020

Build installer for Windows in Appveyor so a it can be attached to releases.

Installer:

  • Installs the program per-user basis.
  • User can choose to enable "start on startup" during the installation.

Tested with Wine but should work with native Windows.

@Lihis Lihis added the windows Windows specific issue label Feb 8, 2020
@Lihis Lihis added this to the v0.1.0 milestone Feb 8, 2020
@doouz
Copy link
Contributor

doouz commented Feb 9, 2020

Errors in VS2017 when compiling https://pastebin.com/bNG1TvP3

C:\Users\Donato\CMakeBuilds\39513d3b-5305-423c-9135-74fba073e7b1\build\x64-Release\gui\MainWindow.cpp.obj : error LNK2019: unresolved external symbol "public: virtual __cdecl base::AboutDialog::~AboutDialog(void)" (??1AboutDialog@base@@UEAA@XZ) referenced in function "public: virtual __cdecl AboutDialog::~AboutDialog(void)" (??1AboutDialog@@UEAA@XZ) 

C:\Users\Donato\CMakeBuilds\39513d3b-5305-423c-9135-74fba073e7b1\build\x64-Release\gui\MainWindow.cpp.obj : error LNK2019: unresolved external symbol "public: __cdecl AboutDialog::AboutDialog(class wxWindow *)" (??0AboutDialog@@QEAA@PEAVwxWindow@@@Z) referenced in function "private: void __cdecl MainWindow::on_about(class wxCommandEvent &)" (?on_about@MainWindow@@AEAAXAEAVwxCommandEvent@@@Z) 

C:\Users\Donato\CMakeBuilds\39513d3b-5305-423c-9135-74fba073e7b1\build\x64-Release\bin\ets2-job-logger.exe : fatal error LNK1120: 2 unresolved externals 

@Lihis
Copy link
Owner Author

Lihis commented Feb 9, 2020

Can not be related to this PR, does that happen in master branch?

@doouz
Copy link
Contributor

doouz commented Feb 9, 2020 via email

@Lihis
Copy link
Owner Author

Lihis commented Feb 9, 2020

Visual Studio is borked? It's building just fine in Appveyor.

@doouz
Copy link
Contributor

doouz commented Feb 9, 2020

My bad, sorry, I was using the old cmake cache generated by VS2017, I deleted the cache and regenerate again and now is compiled wihtout errors :), thank you!

I will test the installer and answer again in some minutes to confirm that is working.

@doouz
Copy link
Contributor

doouz commented Feb 9, 2020

All is working great!

@doouz
Copy link
Contributor

doouz commented Feb 10, 2020

Maybe will be a good idea to have an update procedure like this https://stackoverflow.com/a/53079610 avoiding the /silent part because the idea is that it does not generate problems, out there someone has the game open and an update closes the program to unlock the plugin file and install the update and with the game open that cannot be done. But will be helpful that the app check like every 30 minutes the API URL with /version endpoint and /version will return actual_version and download_url so the APP can compare the version that is configured in some variable in the app code against actual_version and if actual_version > version then user download_url to download and run the new installer.

Also, this is not so important, is more like a "nice to have" and not a "must have". Anyone can use a program like advanced installer to create an installer with update system, in my case I have it that way and it works fine for me, also advanced installer create the installer in more languages, spanish in my case.

@Lihis
Copy link
Owner Author

Lihis commented Feb 10, 2020

That would be nice.

If Advanced Installer has that as a feature I wouldn't mind if someone sponsor a license so it can be used in Appveyor.

@Lihis Lihis added the enhancement New feature or request label Feb 17, 2020
@Lihis Lihis merged commit 4d708ea into master Feb 23, 2020
@Lihis Lihis deleted the build-windows-installer branch February 23, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request windows Windows specific issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants