-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build installer for Windows #40
Conversation
Errors in VS2017 when compiling https://pastebin.com/bNG1TvP3
|
Can not be related to this PR, does that happen in |
Just happen in this PR.
El El dom, 9 de feb. de 2020 a la(s) 07:43, Tomi Lähteenmäki <
notifications@github.com> escribió:
… Can not be related to this PR, does that happen in master branch?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#40?email_source=notifications&email_token=AN7NGSBJDGFEWX22KARSYN3RB7M35A5CNFSM4KR2P2J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGIVWA#issuecomment-583830232>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN7NGSGBGBSDBYM5ESNVWK3RB7M35ANCNFSM4KR2P2JQ>
.
|
Visual Studio is borked? It's building just fine in Appveyor. |
My bad, sorry, I was using the old cmake cache generated by VS2017, I deleted the cache and regenerate again and now is compiled wihtout errors :), thank you! I will test the installer and answer again in some minutes to confirm that is working. |
All is working great! |
Maybe will be a good idea to have an update procedure like this https://stackoverflow.com/a/53079610 avoiding the /silent part because the idea is that it does not generate problems, out there someone has the game open and an update closes the program to unlock the plugin file and install the update and with the game open that cannot be done. But will be helpful that the app check like every 30 minutes the API URL with /version endpoint and /version will return actual_version and download_url so the APP can compare the version that is configured in some variable in the app code against actual_version and if actual_version > version then user download_url to download and run the new installer. Also, this is not so important, is more like a "nice to have" and not a "must have". Anyone can use a program like advanced installer to create an installer with update system, in my case I have it that way and it works fine for me, also advanced installer create the installer in more languages, spanish in my case. |
That would be nice. If |
Build installer for Windows in Appveyor so a it can be attached to releases.
Installer:
Tested with Wine but should work with native Windows.