update install location & add systemwide option #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 84.37% 81.64% -2.73%
==========================================
Files 1 1
Lines 128 158 +30
==========================================
+ Hits 108 129 +21
- Misses 20 29 +9
Continue to review full report at Codecov.
|
|
This PR was complicated by the fact that
|
|
The issue was passing an invalid |
LilithHafner
commented
Dec 4, 2021
src/UpdateJulia.jl
Outdated
Comment on lines
21
to
44
| function default_install_location(systemwide, v) | ||
| default = if systemwide | ||
| @os "\\Program Files" "/Applications" "/opt" | ||
| else | ||
| (joinpath(homedir(), (@os "AppData\\Local\\Programs" "Applications" ".local"))) | ||
| end | ||
| current = dirname(dirname( | ||
| @static Sys.isapple() ? dirname(dirname(dirname(Base.Sys.BINDIR))) : Base.Sys.BINDIR)) | ||
|
|
||
| if current == default || (@static Sys.isunix() && (@static !Sys.isapple() && startswith(current, "/opt/julia"))) | ||
| current | ||
| else | ||
| println("julia-$VERSION is currently installed in $current. Install julia-$v in $default instead? Y/n") | ||
| response = readline(stdin) | ||
| if isempty(response) || uppercase(first(response)) == 'Y' | ||
| default | ||
| elseif uppercase(first(response)) == 'N' | ||
| current | ||
| else | ||
| error("Unknown input: $response. Expected 'y' or 'n'.") | ||
| end | ||
| end | ||
| end | ||
|
|
LilithHafner
commented
Dec 4, 2021
Comment on lines
+70
to
+73
| set_default = (@static Sys.iswindows() ? false : v==latest()), | ||
| systemwide = !startswith(Base.Sys.BINDIR, homedir()), | ||
| install_location = default_install_location(systemwide, v), | ||
| bin = (@static Sys.iswindows() ? nothing : (systemwide ? "/usr/local/bin" : joinpath(homedir(), ".local/bin"))), |
|
Need to document this behavior! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7