Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reaching the max alloc size with the custom gc #78

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

radkomih
Copy link
Collaborator

Detailed description:

Which issue(s) this PR fixes:
Fixes #77

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@radkomih radkomih self-assigned this Aug 31, 2023
@radkomih radkomih force-pushed the fix-max-alloc-size-during-encode branch from 2c2bee9 to 89f6338 Compare August 31, 2023 12:54
@radkomih radkomih force-pushed the fix-max-alloc-size-during-encode branch from 89f6338 to 227ebb6 Compare August 31, 2023 12:55
@radkomih radkomih requested a review from failfmi August 31, 2023 12:55
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #78 (227ebb6) into master (9b6f9f8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   34.87%   34.91%   +0.03%     
==========================================
  Files          23       23              
  Lines        1898     1899       +1     
==========================================
+ Hits          662      663       +1     
  Misses       1227     1227              
  Partials        9        9              
Files Changed Coverage Δ
fixed_length.go 79.83% <100.00%> (+0.16%) ⬆️

@radkomih radkomih merged commit 09f87c3 into master Aug 31, 2023
1 check passed
@radkomih radkomih deleted the fix-max-alloc-size-during-encode branch August 31, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hitting the max possible allocation size when U8 encoding with the custom gc
3 participants