This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
plugins: Fix URL returned by github plugin to the UI #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwasilew
force-pushed
the
fix-gh-plugin-redirect-url
branch
from
69caa49
to
33ccb9f
Compare
Github API has changed since the plugin was created. The new URL fixes HTTP 404 status. It's still not ideal as it leads to the JSON object instead of the nice web UI. Signed-off-by: Milosz Wasilewski <milosz.wasilewski@foundries.io>
mwasilew
force-pushed
the
fix-gh-plugin-redirect-url
branch
from
33ccb9f
to
1c00073
Compare
|
I added a test to cover |
|
@mwasilew thanks for the fix, I'm yet to find the time to get the coverage above 80%, I'll work on a squad feature this week, will look into increase testing coverage then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github API has changed since the plugin was created. The new URL fixes HTTP 404 status. It's still not ideal as it leads to the JSON object instead of the nice web UI.
https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#get-a-commit