This repository has been archived by the owner on Jul 25, 2024. It is now read-only.
Change important_metadata to follow order from "Important metadata keys" #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katieworton
force-pushed
the
master
branch
2 times, most recently
from
dbf4b40
to
53c5416
Compare
Move sorting of metadata from views to models so it is easier to test ordering of build metadata.
Change important metadata so it returns in the order specified in the important metadata field rather than applying the sorted function to determine the order.
chaws
approved these changes
Sep 20, 2023
|
Tests are passing locally but something popped up on github. I'm merging this now and will deal with GH failures later |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the important_metadata field so the items are displayed in the order from the "Important metadata keys" project setting rather than alphabetically sorting the list.