Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uadk: adjust internal file include relationships #527

Closed
wants to merge 0 commits into from
Closed

uadk: adjust internal file include relationships #527

wants to merge 0 commits into from

Conversation

Liulongfang
Copy link
Collaborator

The file inclusion relationship in the current uadk is confusing, and there are multiple repeated inclusions, which leads to confusion in the internal inclusion relationship.

In addition, the interface to the APP application layer and the interface to the user mode driver layer are mixed together, making it inconvenient for the APP application layer to use UADK. After adjustment, when the APP application layer calls the uadk interface to execute services, it only needs to call the header file of the corresponding algorithm , and driver development only needs to include its own header file and the driver-side interface of the corresponding algorithm.

@gaozhangfei
Copy link
Collaborator

+1

Tested OK on x86 and arm.

Two warning can be fixed, others are ok
WARNING: Missing a blank line after declarations
#715: FILE: wd_util.c:152:

  •   struct wd_ctx_h *ctx = (struct wd_ctx_h *)h_ctx;
    
  •   if (!ctx || qfrt >= UACCE_QFRT_MAX)
    

WARNING: suspect code indent for conditional statements (8, 24)
#715: FILE: wd_util.c:152:

  •   if (!ctx || qfrt >= UACCE_QFRT_MAX)
    
  •                   return 0;
    

@Liulongfang
Copy link
Collaborator Author

OK! Thanks you! I'll change it

@Liulongfang
Copy link
Collaborator Author

@hzhuang1 ,Please help to review

@hzhuang1
Copy link
Collaborator

I'm fine on this.
@haofang111 What's your opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants