-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plantuml diagrams support #165
Conversation
Hi @DanZ-ix, Thats again a nice implementation. Did not have the time to test it yet. Would it be possible to make it like the mermaid plugin, inside a codeblock? (I know there is no documentation on this one yet...). I guess that makes more sense to me. ```mermaid So it would be ```plantuml Alice -> Bob: Another authentication Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few small changes need to be made and then its ready for merging. It worked great!
Summary
Added plantuml plugin, added plugin method process_md_before_html_convert(md: str) -> str, added dcoumentation
Details
Plantuml plugin support
New plugin can be used with tags [[plantuml start]] CODE [[plantuml end]], for example:
This block is rendered using plantuml server (default is plantuml.com, custom can be defined with config) as an png diagram.
Plantuml code can be edited in .md file and after saving the diagram would be changed.
Two or more plantuml blocks are supported
New optional plugin method
Added new optional plugin method
process_md_before_html_convert(md: str) -> str
, that is called before converting .md file to html, but after saving it to the filesystem. It allows to make changes in md file that are not saved, but rendered in html.Checks
docs/<corresponding file>