Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to search results #73

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

kura
Copy link
Contributor

@kura kura commented Sep 11, 2022

Summary

Add pagination to search results

Details

Adds pagination to search results rather than only display the top 10 results.

Here are a couple of screenshots of how it'll look in light mode and dark mode. Please note that to easily test pagination here I simply copied the Features.md document 20 times and changed the filename, hence all the results are for features.

If there is only one page of search results, the pagination is not displayed

Checks

  • Tested changes

@kura kura force-pushed the feature-search-pagination branch 4 times, most recently from 8cf5c95 to 9a4f2d5 Compare September 11, 2022 13:35
@kura
Copy link
Contributor Author

kura commented Sep 11, 2022

Not sure why that test is failing on Python 3.8, it works locally. Maybe a timing issue?

@Linbreux
Copy link
Owner

@kura Looks great! Nice implementation.

@Linbreux Linbreux merged commit e49da69 into Linbreux:main Sep 11, 2022
@kura
Copy link
Contributor Author

kura commented Sep 11, 2022

@Linbreux thanks.

I may make additional tweaks to the search system over the next few weeks too. I'm thinking about messing around with facets (something like allowing you to filter the results by sub directory) and stemming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants