Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small code improvements #74

Merged
merged 2 commits into from
Sep 11, 2022

Conversation

Oliver-Hanikel
Copy link
Contributor

Summary

Fixed some typos and fixed some issues with the code / made it more readable.

Details

  • use os.path.join and f-strings instead of concatenating strings
  • remove unneeded imports
  • create the upload folder if it does not exist
  • remove unneeded statements in knowledge-graph.html
  • make list_files.html more readable
  • close a tags in list_files.html and search.html
  • new.html
    • use navigator.clipboard.writeText instead of document.execCommand since it is deprecated
    • create the message texts more idiomatically

Checks

  • Tested changes

 - use os.path.join and f-strings instead of concatenating strings
 - remove unneeded imports
 - create the upload folder if it does not exist
 - remove unneeded statements in knowledge-graph.html
 - make list_files.html more readable
 - close a tags in list_files.html and search.html
 - new.html
   - use navigator.clipboard.writeText instead of document.execCommand since it is deprecated
   - create the message texts more idiomatically
@Linbreux
Copy link
Owner

@Oliver-Hanikel Looks great, thanks!

@Linbreux Linbreux merged commit 0020ece into Linbreux:main Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants