Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC updates and additions. Sync fix. #45

Closed
wants to merge 25 commits into from
Closed

RPC updates and additions. Sync fix. #45

wants to merge 25 commits into from

Conversation

davidstoneham
Copy link

@davidstoneham davidstoneham commented Apr 4, 2018

Critical Fix

Fixed issue where wallet was stuck on syncing block 0 when syncing a new blockchain

Sync Improvements

  • track peer block downloads to auto remove stalled peers
  • disconnect peer when reached ban threshold (needs proper ban logic implemented)
  • disallows access to nodes running wallets less than 2.0.0.0
  • dump orphan blocks from peer when they are disconnected (prevents filling orphan block list with unusable blocks)
  • add maxorphantx startup flag to cap max orhpan transactions held in memory for running on lightweight machines

General Improvements

  • masternode should ignore if wallet is unlocked for staking only
  • locked masternode coins will be ignored when staking
  • masternode start will check all possible coin inputs instead of just the first

General RPC improvements

  • Updates listreceivedbyaddress RPC command to return only your addresses when running with minconf=0 and includeempty=true instead of returning all addresses including send addresses from your address book.

  • fix GetAccountAddress not committing the new account to the walletdb causing duplicates to be made when running the command again

  • setaccount no longer can create new addresses. This was a confusing feature and gave no way to change account names without creating new addresses

  • setaccount returns error if trying to change the account of an address that doesn't exist in your wallet

  • listreceived now returns (change) addresses

Added RPC commands for masternodes

  • masternode status - dumps your masternode status. includes your active time and status to determine if your masternode is running correctly
    -masternode status-all - dumps the above info for all masternodes on the network (only your masternode will include status field)
  • masternode init ip:port - allows you to initialise your masternode without editing the linda.conf or masternode.conf files and or restarting the program. Running masternode start will then start your masternode
  • masternode addremote ip:port - adds the info to your masternode.conf file (no need to restart Linda-qt or Lindad) running start-many or start-alias will start the appropriate remote masternodes
  • masternode removeremote - removes the related account from your masternode.conf file (no need to restart Linda-qt or Lindad) you will need to run the masternode stop to stop these masternodes
  • masternode isInit - returns boolean if masternode is enabled and capable of running
  • masternode kill - disables masternode. can be re-enable by running init command

setaccount returns an error if the address isn't in your wallet
fix setaccount creating new addresses
@davidstoneham davidstoneham changed the title fix listreceivedbyaddress returning sending addresses from address book fix RPC related issues Apr 5, 2018
@nisanb
Copy link
Collaborator

nisanb commented Apr 9, 2018

Will be reviewed.
Thanks

@davidstoneham davidstoneham changed the title fix RPC related issues RPC updates and additions. Sync fix. Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants