Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the strange implementation of BDSS ignoring tree operator #121

Open
walterxie opened this issue Sep 22, 2023 · 2 comments
Open

Handle the strange implementation of BDSS ignoring tree operator #121

walterxie opened this issue Sep 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@walterxie
Copy link
Collaborator

It seems BDSS https://github.com/fkmendes/bdtree/tree/master ignores tree root operator and scale operator, if the XML BDSS is given one value below:

<distribution id="BirthDeathSequentialSampling" spec="bdtree.likelihood.BirthDeathSequentialSampling" rootAge="81.34374515244996" tree="@psi">

So, only when the above XML is change to use lower="1.0" upper="100.0", these two tree operators are working.

@walterxie walterxie added the enhancement New feature or request label Sep 22, 2023
@walterxie
Copy link
Collaborator Author

The problem is how to find the Generator's bound for any distributions if not uniform?

@walterxie walterxie added the bug Something isn't working label Sep 22, 2023
@walterxie
Copy link
Collaborator Author

Not sure why we need MRCAPrior. BirthDeathSequentialSampling does not have this input.

@walterxie walterxie removed the bug Something isn't working label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant