Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #10

Merged
merged 6 commits into from
Aug 23, 2018
Merged

Dev #10

merged 6 commits into from
Aug 23, 2018

Conversation

brohammer
Copy link

No description provided.

@schae234
Copy link
Member

Hey @brohammer This looks great and will be really useful! I'm going to merge it into the dev branch and check out what Travis is angry about.

@schae234 schae234 merged commit d44e297 into LinkageIO:dev Aug 23, 2018
@brohammer
Copy link
Author

Hey @schae234 Yeah, sorry I didn't check what was going on with the tests. I've been using the functions in 5307eb1 for awhile in my fork so they shouldn't cause too many issues. I can write out some documentation summary on what I added if desired. Sorry it took me so long to push.

@schae234
Copy link
Member

Yeah, I think the tests just look for particular function signatures/parameters, so they just need to be updated to use your new function calls. Once the tests pass we can merge into the master branch which will make all your functions available when people install the package through using pip.

Ill let you know if something trips me up with what you added, otherwise what you did looks pretty straight forward 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants