-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support {:else} blocks in @first, @last #143
base: master
Are you sure you want to change the base?
Conversation
Not sure why the Travis build is failing, but the error seems unrelated. Any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For style purposes, could you follow the pattern in the filter
function with skip
and nonternary return values?
The helpers build uses loose versioning for the Jasmine dep and it's changed out from under you, not your fault. Would you mind adding a test? Once this is merged you can open a PR against the gh-pages branch of the main Dust repo for the docs. Thanks a bunch for the PR! |
Thanks. The format is consistent now and I added two tests. They're my first unit tests so feel free to suggest changes. 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Nice, thanks for taking the time to send a PR! :) |
@jimmyhchan #138 will fix the test failures, I'll try to work on it soon... |
Simple PR to add support for
{:else}
in@first
and@last
helpers, per linkedin/dustjs#720.575 tests, 837 assertions, 0 failures, 0 skipped