Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the event bus with a global storage and a class. #3

Closed
LinusBorg opened this issue Feb 13, 2017 · 1 comment
Closed

Replace the event bus with a global storage and a class. #3

LinusBorg opened this issue Feb 13, 2017 · 1 comment
Assignees
@LinusBorg
Labels
enhancement
Milestone
1.0.0

Comments

@LinusBorg
Copy link
Owner

LinusBorg commented Feb 13, 2017 •
edited
Loading

Problem with the Event Bus:

We can see race conditions if one portal is removed (and calls clear()) and another portal is created (and calls sendUpdate()). If the latter component is updating before the former, clear() will remove the content of sendUpdate().

The solution is to queue these events, which the Event bus does not allow.
@LinusBorg LinusBorg self-assigned this Feb 13, 2017
@LinusBorg LinusBorg added this to the 1.0.0 milestone Feb 13, 2017
@LinusBorg LinusBorg mentioned this issue Feb 13, 2017
Closed
9 tasks
@LinusBorg LinusBorg removed their assignment Feb 13, 2017
@LinusBorg LinusBorg added Tests and removed Tests labels Feb 13, 2017
@LinusBorg LinusBorg self-assigned this Feb 13, 2017
LinusBorg added a commit that referenced this issue Feb 13, 2017
@LinusBorg
Implement better Bus System. (#3)
8f2af80
@LinusBorg
Copy link
Owner Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LinusBorg LinusBorg

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@LinusBorg