fix: use stableSort routine when sorting transports. Fixes #152, #141 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, highly apprchiated. But I think there might be something missing from your PR? You added the |
|
Weird, I had made a second edit to wormhole.js to use stable sort, but looks like it didn't make it in on the PR.. I'll update |
|
commit re-pushed to actually use stableSort |
|
@LinusBorg should be all fixed up now |
|
Thanks, I'll check it out. |
LinusBorg
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses stable sort routine rather than native
Array.prototype.sortto ensure a consistent sort across browser platforms and array sizes... (I'm looking at you Chrome 👿 )Stable Sort preserves original array order when elements end up with a compare result of
0, by comparing by the original position (index) in the original array.Fixes #152, and most likely #141