Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whole system interactions should honor resources config when open=false #3390

Closed
d0roppe opened this issue Feb 24, 2022 · 4 comments
Closed

Whole system interactions should honor resources config when open=false #3390

d0roppe opened this issue Feb 24, 2022 · 4 comments
Assignees
@lmsurpre
Labels
bug Something isn't working P2 Priority 2 - Should Have

Comments

@d0roppe
Copy link
Collaborator

d0roppe commented Feb 24, 2022 •
edited by lmsurpre
Loading

Describe the bug
with fhirServer/resource configurations in fhir-server-config.json with resources listed, and open=false. Whole system search should only work on the resources listed

server log contains exception

Environment
FHIR main
@lmsurpre
Copy link
Member

this work was already implemented in our r4b-rebased branch as part of #3242 ...what we need to do is backport that to our main branch

@lmsurpre lmsurpre self-assigned this Mar 11, 2022
@lmsurpre lmsurpre added P2 Priority 2 - Should Have bug Something isn't working labels Mar 14, 2022
@lmsurpre
Copy link
Member

consider adding integration test that has an open=false and performs a whole-system-interaction

lmsurpre added a commit that referenced this issue Mar 15, 2022
@lmsurpre
issue #3390 - whole-system interactions use config
cef7f9b 
* Introduce the ResourceTypeName enum in fhir-core and ResourcesConfigAdapter in fhir-config
* Use ResourcesConfigAdapter from whole-system search, whole-system history, $everything, and $export

I also started on #3319 - system-search now supports multiple instances of the `_type` parameter

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 16, 2022
@lmsurpre
issue #3390 - whole-system interactions use config
63d1d19 
* Introduce the ResourceTypeName enum in fhir-core and ResourcesConfigAdapter in fhir-config
* Use ResourcesConfigAdapter from whole-system search, whole-system history, $everything, and $export

I also started on #3319 - system-search now supports multiple instances of the `_type` parameter

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre changed the title with resource configuration parameters with open=false whole system search should honor Whole system interactions should honor resource configuration when open=false Mar 16, 2022
@lmsurpre lmsurpre changed the title Whole system interactions should honor resource configuration when open=false Whole system interactions should honor resources config when open=false Mar 16, 2022
lmsurpre added a commit that referenced this issue Mar 16, 2022
@lmsurpre
issue #3390 - whole-system interactions use config
c142954 
* Introduce the ResourceTypeName enum in fhir-core and ResourcesConfigAdapter in fhir-config
* Use ResourcesConfigAdapter from whole-system search, whole-system history, $everything, and $export

I also started on #3319 - system-search now supports multiple instances of the `_type` parameter

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 16, 2022
@lmsurpre
issue #3390 - whole-system interactions use config
34f3653 
* Introduce the ResourceTypeName enum in fhir-core and ResourcesConfigAdapter in fhir-config
* Use ResourcesConfigAdapter from whole-system search, whole-system history, $everything, and $export

I also started on #3319 - system-search now supports multiple instances of the `_type` parameter

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@d0roppe
Copy link
Collaborator Author

d0roppe commented Mar 23, 2022

running this with the added resource "Resource" to allow whole system search to work with no parms, we still return resources not listed in the resources section of the fhir-server-config.json file.

lmsurpre added a commit that referenced this issue Mar 24, 2022
@lmsurpre
issue #3390 - add implicit search/history _type scoping
a96c309 
When the fhirServer/resources config restricts search or history on one
or more resource types, we now add an implicit _type parameter to the
request to filter it down to just the resource types that support the
given interaction.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 24, 2022
@lmsurpre
issue #3390 - add implicit search/history _type scoping
0394a22 
When the fhirServer/resources config restricts search or history on one
or more resource types, we now add an implicit _type parameter to the
request to filter it down to just the resource types that support the
given interaction.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 24, 2022
@lmsurpre
issue #3390 - add implicit search/history _type scoping
5e6557d 
When the fhirServer/resources config restricts search or history on one
or more resource types, we now add an implicit _type parameter to the
request to filter it down to just the resource types that support the
given interaction.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 24, 2022
@lmsurpre
issue #3390 - add implicit search/history _type scoping
3c249c0 
When the fhirServer/resources config restricts search or history on one
or more resource types, we now add an implicit _type parameter to the
request to filter it down to just the resource types that support the
given interaction.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 24, 2022
@lmsurpre
issue #3390 - add implicit search/history _type scoping
bd3b1f4 
When the fhirServer/resources config restricts search or history on one
or more resource types, we now add an implicit _type parameter to the
request to filter it down to just the resource types that support the
given interaction.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Mar 31, 2022
@lmsurpre
Merge pull request #3504 from IBM/issue-3390
2378ef6 
issue #3390 - add implicit search/history _type scoping
@d0roppe
Copy link
Collaborator Author

d0roppe commented Mar 31, 2022

Now with "open": = false for the resources configuration, a whole system search now gets appended with _type= for the resource types noted in the configuratiopn. So now the whole system search works as expected with the "open": = false

@d0roppe d0roppe closed this as completed Mar 31, 2022
lmsurpre added a commit that referenced this issue Apr 5, 2022
@lmsurpre
issue #3390 - align ResourceTypeName with the R4 ResourceType enum
a10cd54 
I could have sworn I did this before, but its definitely out-of-sync in
main. This changeset re-aligns the two so that:
1. we don't end up trying to us a resource type that doesn't exit in R4
2. we don't miss any resource types that existed in R4 but are being
removed for R4B

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 5, 2022
@lmsurpre
issue #3390 - align ResourceTypeName with the R4 ResourceType enum
0390f50 
I could have sworn I did this before, but its definitely out-of-sync in
main. This changeset re-aligns the two so that:
1. we don't end up trying to us a resource type that doesn't exit in R4
2. we don't miss any resource types that existed in R4 but are being
removed for R4B

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 5, 2022
@lmsurpre
issue #3390 - align ResourceTypeName with the R4 ResourceType enum (#…
a195cfc 
…3561)

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

Labels
bug Something isn't working P2 Priority 2 - Should Have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmsurpre @d0roppe