issue #1198 performance enhancement for patient/group export #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
prb112
reviewed
Jun 9, 2020
fhir-bulkimportexport-webapp/src/main/java/com/ibm/fhir/bulkexport/patient/ChunkReader.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jun 9, 2020
fhir-bulkimportexport-webapp/src/main/java/com/ibm/fhir/bulkexport/patient/ChunkReader.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jun 9, 2020
fhir-bulkimportexport-webapp/src/main/java/com/ibm/fhir/bulkexport/patient/ChunkReader.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jun 9, 2020
fhir-bulkimportexport-webapp/src/main/java/com/ibm/fhir/bulkexport/patient/ChunkReader.java
Show resolved
Hide resolved
Signed-off-by: Albert Wang <xuwang@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance enhancement:
changed to get resources for the whole page of patients in one query for each compartment search criteria instead of do compartment search for the resource type patient by patient.
According to the test results, this has improved the export performance by more than 10 times.
Signed-off-by: Albert Wang xuwang@us.ibm.com