Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ear creation #57 #156

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Fix for ear creation #57 #156

merged 2 commits into from
Oct 2, 2019

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Sep 26, 2019

No description provided.

@prb112 prb112 self-assigned this Sep 26, 2019
@prb112
fix for ear creation #57
155c147 
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
Copy link
Contributor Author

prb112 commented Sep 26, 2019

This is an investigation only. If it works, we can consider merging it. I'm sharing here to not lose track.

albertwang-ibm
albertwang-ibm approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@albertwang-ibm albertwang-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried in my local Env, this solution works really well!! LGTM

@prb112 prb112 changed the title WIP: fix for ear creation #57 Fix for ear creation #57 Oct 2, 2019
@prb112 prb112 added this to the Sprint 2 milestone Oct 2, 2019
@prb112 prb112 added the bug Something isn't working label Oct 2, 2019
@prb112
Copy link
Contributor Author

prb112 commented Oct 2, 2019

Albert reported that this works.

@lmsurpre when you get a chance can you verify too.

lmsurpre
lmsurpre approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got around to trying this. Took a fresh clone and imported into a fresh workspace and not a single EAR project generated. Nice job Paul!

@lmsurpre lmsurpre merged commit 48d2d28 into master Oct 2, 2019
@lmsurpre lmsurpre deleted the issue-57-sept branch October 2, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertwang-ibm albertwang-ibm albertwang-ibm approved these changes

@lmsurpre lmsurpre lmsurpre approved these changes

Assignees

@prb112 prb112

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 2
Development

Successfully merging this pull request may close these issues.
3 participants
@prb112 @lmsurpre @albertwang-ibm