Issue #2527162: Cannot call global functions that take a method by reference #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $Args = array(); | ||
| foreach($args as $k => &$arg){ | ||
| $Args[$k] = &$arg; | ||
| } |
There was a problem hiding this comment.
I have used this hack myself before! 👍 I love it :-D.
Lets use $args_reference though instead of $Args and $key => &$arg.
| @@ -43,7 +43,14 @@ | |||
| class Drupal7 { | |||
|
|
|||
| public function __call($method, $args) { | |||
| return call_user_func_array($method, $args); | |||
| // Hack: See http://goo.gl/aM5fra | |||
There was a problem hiding this comment.
Lets have this say something like:
// This is a necessary hack to ensure that things that have been passed by reference continue to being passed by reference. For more information see: ...
There was a problem hiding this comment.
Reason: If I see a module with lots of: // Hack, etc.
I usually decide to not use it.
There was a problem hiding this comment.
I wouldn't call this a "hack", this is a very clever way to do something, but I don't consider this as a hack.
drupol
added a commit
that referenced
this pull request
Jul 6, 2015
Issue #2527162: Cannot call global functions that take a method by reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://www.drupal.org/node/2527162