Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotations_export #11

Open
andrbru opened this issue Aug 15, 2022 · 1 comment
Open

annotations_export #11

andrbru opened this issue Aug 15, 2022 · 1 comment

Comments

@andrbru
Copy link

andrbru commented Aug 15, 2022

I started working on exporting the EDF Annotations, and probably found some errors there as well.

The first is simple -- if there are no standard channels, an if-statement skips the whole signal writing method, so a file with only annotation signals cannot be exported. I think its better to allow such files, since even official specs mention EDF files with only annotations in the introduction.

Additionaly, it seems there is something wrong with saving of the TALs. I tryed to create files using this library and my results were on the one hand readable with the library itself, but on the other hand displayed as "Annotations are not EDF+" in Polyman.

@andrbru
Copy link
Author

andrbru commented Aug 15, 2022

I went though the code and tried to understand it. I think the saving method for EDF Annotations signals saves one TAL per AnnoSignal per datarecord, or at least writes it's "annotation index" regardles if there's any annotation message (correct me if i got it wrong). But according to the EDF+ specs, it's allowed to save an arbitrary amount of TALs in one AnnoSignal into one datarecord. Meanwhile the compulsory time index specifying the time of the start of a datarecord can be written only once per datarecord, in the first TAL of the first AnnoSignal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant