-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong_parse_of_a_tal #9
Comments
More files where I believe the same is happening, in case you could have use of them for testing. |
I'll check :) |
I was confused with the specifications actually. I just parsed each annotation from the files. |
hi @andrbru . I pushed a fix for this. should be OK now. |
Good! I'll try the fixed version. If I understand it correctly than your naming convention is other than the one used in EDF specs. But since some people are already using your library, it might not be good to change the names... |
I think it is better to fix the naming to match the spec for future use. |
Besides form that, I noticed that your library loads a huge number of EDF Annotations signals from a file which Polyman displays as having only one. But I believe that's because Polyman always displays only one EDF Annotations signal regardless of how many there accualy are in file bytes. Also, have I noticed correctly that if there are any EDF Annotations signal(s), your library adds one EDF Annotations signal into the array of standard signals? Why that? |
I think for backward compatibility the annotation are created as "standard" signals. There are many improvements that can be done to the library. I just started working on it (based on other people work) not long ago.. |
It does't cause any trouble. I simply made an IF sorting that channel out so there won't be two of annotations signals. I understand, there is allways sometrnig to improve. It's still the best EDF library for C# I have found, since it is the only one implementing annotations from EDF+. I hope the errors that I report here will help you improve it. |
I might have found a file where the first TAL is read incorrectly.
Besides the file, I enclose a photo of comparsion of the annotations as displayed in Polyman (right) and in program I am implementing a EDF reading for (left) where I just used the new version of your library. It seems as if time and duration was read as a part of description.
Just one detail: in your namespace, a TAL means an annotation, i. e. message with timing? In EDF specs, it means a Time stamped Annotation List , i. e. list of messages sharing sa
files.zip
me timing.
The text was updated successfully, but these errors were encountered: