This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Fix multiple new passphrase windows bug - Closes #16 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 2, 2017 15:03
autofocus passphrase field submit by enter
|
Sorry about adding other commits to this pull request, they didn't look like big enough changes to have their own branch. |
karmacoma
changed the title
4miners
approved these changes
Mar 6, 2017
karmacoma
approved these changes
Mar 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing $timeout seems to fix the issue. I was able to reproduce it multiple times, before doing the change and never after doing the change. I'm just worried what was a purpose of the $timeout being there in the first place.
Closes #16