Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add unit test coverage for db/repos/migrations #1589

Closed
nazarhussain opened this issue Feb 19, 2018 · 3 comments
Closed

Add unit test coverage for db/repos/migrations #1589

nazarhussain opened this issue Feb 19, 2018 · 3 comments
Assignees

Comments

@nazarhussain
Copy link
Contributor

Parent: #1484

Expected behavior

We need 100% coverage for db/repos/migrations

Actual behavior

Currently there is no coverage for this repo.

@karmacoma
Copy link
Contributor

Reopened to address failing tests encountered by: #1637 and due to reversion to old promise syntax. Failing tests have been skipped for now.

@karmacoma karmacoma reopened this Feb 26, 2018
@nazarhussain
Copy link
Contributor Author

@vitaly-t Please looked the skipped tests specifically

https://github.com/LiskHQ/lisk/blob/1.0.0/test/unit/db/repos/migrations.js#L298

And suggest some pattern/approach to test functions which involving transactions and generator functions.

@nazarhussain
Copy link
Contributor Author

@vitaly-t FYI, based on discussion with @karmacoma I had reverted your changes that was causing failures of test cases. Had created the respective issue vitaly-t/pg-promise#479

You do acknowledge that we love pg-promise and more importantly want to write clean and beautiful constructs introduced by you, but we have a principle that ugly code is better than beautiful but non-testable code.

As soon you fix that particular issue in pg-promise, will introduce the changes again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants