Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add unit test coverage for db/repos/migrations - Closes #1589 #1681

Merged
merged 3 commits into from
Mar 14, 2018

Conversation

nazarhussain
Copy link
Contributor

What was the problem?

The introduction of txIf break the transaction context which causes failure of different unit tests.

How did I fix it?

Reverted the changes and created the respective issue on pg-promise vitaly-t/pg-promise#479

How to test it?

npx mocha test/unit/db/repos/migrations.js

Review checklist

@karmacoma karmacoma changed the title Add unit test coverage for db/repos/migrations - Closes#1589 Add unit test coverage for db/repos/migrations - Closes #1589 Mar 6, 2018
@karmacoma karmacoma assigned MaciejBaj and unassigned karmacoma Mar 13, 2018
@MaciejBaj MaciejBaj requested a review from 4miners March 13, 2018 16:00
@4miners 4miners self-assigned this Mar 13, 2018
@MaciejBaj MaciejBaj merged commit edd41ff into 1.0.0 Mar 14, 2018
@MaciejBaj MaciejBaj deleted the 1589-db-migrations-test branch March 14, 2018 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants