Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add capability to register database migration from the application/module layer #3197

Closed
shuse2 opened this issue Mar 27, 2019 · 0 comments · Fixed by #3701
Closed

Add capability to register database migration from the application/module layer #3197

shuse2 opened this issue Mar 27, 2019 · 0 comments · Fixed by #3701
Assignees

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Mar 27, 2019

Expected behavior

Expect Application class to expose a method called registerMigrations in order to allow applications to define migrations to be run along with the framework migrations.

Also, each module should be able to define its own migrations through the migrations attribute in the module class. By doing so, all chain related migrations should be moved to ChainModule class and all p2p related migrations should be moved to NetworkModule class.

Migrations should be handled by the Controller which will [before loading the modules] get all registered migrations files, order them by date/time and execute the ones not yet executed.

The migration name convention should follow the convention formerly used by Lisk Core: yyyyMMddHHmmss_name_of_migration.sql

Actual behavior

Migrations are handled by Chain Module

Parent

#3146

Which version(s) does this affect? (Environment, OS, etc...)

2.2.0

@shuse2 shuse2 removed this from the Improve Lisk Framework UX - Phase 1 milestone Apr 17, 2019
@shuse2 shuse2 changed the title Move migration to application level Add capability to register database migration from the application layer Apr 17, 2019
@lsilvs lsilvs removed their assignment Apr 17, 2019
@lsilvs lsilvs changed the title Add capability to register database migration from the application layer Add capability to register database migration from the application/module layer May 17, 2019
shuse2 added a commit that referenced this issue May 28, 2019
Add capability to register database migration from the application/module layer - Closes #3197
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants