Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Check if node is actually forging #338

Closed
ghost opened this issue Dec 5, 2016 · 6 comments · Fixed by #363
Closed

Check if node is actually forging #338

ghost opened this issue Dec 5, 2016 · 6 comments · Fixed by #363

Comments

@ghost
Copy link

ghost commented Dec 5, 2016

It would be useful to add endpoint to check if node is currently forging, doesn't matter if many delegates are forging on the same node. I simple need to check if current node is taking part of block generation process at time of check.

@Isabello
Copy link
Contributor

Isabello commented Dec 5, 2016

what would this even do? this can already be checked using other end points.

@ghost
Copy link
Author

ghost commented Dec 5, 2016

for statistics purpose if current node is running ? If there is way, please tell. But as far as i've checked using current endpoint in that case would be overkill while i simply need bool yes or not. Current endpoint would require getting public key of account, checking if it's in top 101 and getting status if forging.

@karmacoma
Copy link
Contributor

@karek314 For what reason do you need to know this information? It is unclear to me.

@4miners
Copy link
Contributor

4miners commented Dec 15, 2016

It can be usefull for some statistics sites like @karek314 one (https://liskstats.net/). But in large network such endpoint can be a security risk for forging delegates - so I recommend closing that issue as wontfix.

@ghost
Copy link
Author

ghost commented Dec 17, 2016

@4miners It does not need to be public, why just not limit some endpoints to be accessible only by user and password defined in config ?

Simply:

  • Allow such endpoints to be accessed localhost only or by specified range of ip's in local network for example.

  • Add authentication for endpoints like this

That functionalities will be useful for other endpoints as well. Actually everything not related to node-2-node connectivity should be more or less limited by why i've said.

@4miners
Copy link
Contributor

4miners commented Dec 18, 2016

Private endpoint is a good idea, I agree. There is already endpoint /api/delegates/forging/status, we can adapt that: #360

karmacoma added a commit that referenced this issue Dec 20, 2016
Redesign /api/delegates/forging/status endpoint.

Closes #360, closes #338.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants