Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add a P2P integration test scenario to cover message propagation in partially connected network #3812

Closed
jondubois opened this issue Jun 12, 2019 · 0 comments
Assignees

Comments

@jondubois
Copy link
Contributor

Expected behavior

  1. There needs to be additional test cases in the P2P integration test scenario https://github.com/LiskHQ/lisk-sdk/blob/5ee62078e683dc89f0eada152f2eab917f6fda34/elements/lisk-p2p/test/integration/p2p.ts#L1318 to check that messages and requests each an appropriate number of peers.

  2. We should mock some additional 'message propagation' functionality into a new test scenario so that each P2P node re-broadcasts a message to its peers during a certain time period, then at the end, we can verify that all the nodes in the network have received the message. The network should have at least 30 nodes.

Actual behavior

  1. For the partial mesh network, currently, we only check peer discovery and connections, but we should also check the p2p.send(...) and p2p.request(...) methods.

  2. Also, we do not currently have an integration test scenario to verify that messages propagate correctly through the network.

Steps to reproduce

Run tests.

Which version(s) does this affect? (Environment, OS, etc...)

Feature branch: feature/implement-lip-p2p

@jondubois jondubois added this to the P2P robust peer selection milestone Jun 13, 2019
@jondubois jondubois changed the title Add an P2P integration test scenario to cover message propagation in partially connected network Add a P2P integration test scenario to cover message propagation in partially connected network Jun 13, 2019
jondubois added a commit that referenced this issue Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants