Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Rate limit WebSocket messages #3975

Closed
jondubois opened this issue Jul 17, 2019 · 0 comments
Closed

Rate limit WebSocket messages #3975

jondubois opened this issue Jul 17, 2019 · 0 comments
Assignees
Milestone

Comments

@jondubois
Copy link
Contributor

jondubois commented Jul 17, 2019

Story
As a node user, I would like to restrict traffic/ messages which I receive from any peer so that I can be safeguarded from the spamming.

Acceptance Criteria

  1. Accept messages/ transaction blocks from each peer when it is not exceeded your Rate limit.
  2. If a specific peer is reached his maximum Rate limit, then the specific peer connection should be interrupted.
  3. The rate limit (receiving limit) can vary from peer to peer.

Expected behavior

There should be a simple rate-limiting mechanism to prevent nodes from spamming our WebSocket connection.

Actual behavior

There is no rate limiting to prevent remote clients from spamming a node's WebSocket connection.

If we have a sufficiently large machine (or multiple machines), we can spam a specific node with WebSocket messages to make it consume CPU.

@jondubois jondubois added this to the P2P resilience milestone Jul 17, 2019
@shuse2 shuse2 removed this from the P2P resilience milestone Jul 17, 2019
@sridharmeganathan sridharmeganathan added this to the Sprint 3 milestone Jul 24, 2019
jondubois added a commit that referenced this issue Jul 31, 2019
Rate limit WebSocket messages - Closes #3975
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants