Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add validation config for system component - Closes #2940 #2987

Closed
wants to merge 40 commits into from
Closed

Add validation config for system component - Closes #2940 #2987

wants to merge 40 commits into from

Conversation

michielmulders
Copy link
Contributor

What was the problem?

No validation present for system component.
Need one without defaults.

How did I fix it?

Added JSON schema validation.

How to test it?

Run application.

Review checklist

nazarhussain and others added 30 commits February 25, 2019 18:34
@nazarhussain
Update the structure of default config file
dc7dcd2
@nazarhussain
Update the structure of alphanet config file
ad5dc37
@nazarhussain
Update the structure of devnet config file
6b048dc
@nazarhussain
Update the structure of betanet config file
45fff5a
@nazarhussain
Update the structure of testnet config file
c038787
@nazarhussain
Update the structure of mainnet config file
209467d
@nazarhussain
Update config migration script to adopt new configuration structure
d1fe8ff
@nazarhussain
Add default configuration with schema for chain module
8a2a79e
@nazarhussain
Add default configuration with schema for http_api module
eec29ab
@nazarhussain
Add default configuration with schema for cache components
817b836
@nazarhussain
Add default configuration with schema for logger components
f3b7520
@nazarhussain
Add default configuration with schema for storage components
df44563
@nazarhussain
Remove central default configuration and schema files
ee9f92c
@nazarhussain
Update constants schema along with default values and description
def179e
@nazarhussain
Add exception schema to chain module and move default exceptions
0d7832f
@nazarhussain
Remove redundent default exception file
29d5211
@nazarhussain
Refactor the custom format registration logic
063ebb7
@nazarhussain
Add a validator that also populdate default values
aeb4e91
@michielmulders @nazarhussain
Implementation caching schema
367e28f
@michielmulders @nazarhussain
Implementation storage schema at component creation
b25124a
@nazarhussain
Refactor the constants schema to make it dynamic validated against ow…
9d1285c 
…n data
@nazarhussain
Remove unused formats for schema validator
b20dc1d
@nazarhussain
Update default values for configuration of chain module
081586f
@nazarhussain
Update default values for configuration of http-api module
b2b6442
@nazarhussain
Update validator to check in reference of validation schema with keyword
d879732
@nazarhussain
Update the module loading logic to pass the validated configurations
60ca79c
@nazarhussain
Update chain module to follow new structure of configuration
e800e68
@nazarhussain
Update application definition to follow new configuration approach
bc4b06d
@nazarhussain
Update http-api module to follow new structure of configuration
fadab0c
@nazarhussain
Fix the ports for devnet configuration
1637bf4
@michielmulders michielmulders self-assigned this Feb 27, 2019
@nazarhussain nazarhussain force-pushed the 2577-modular-configuration branch 5 times, most recently from a61704e to 852449e Compare February 27, 2019 20:04
@nazarhussain nazarhussain force-pushed the 2577-modular-configuration branch 2 times, most recently from 59a488c to af33f72 Compare February 28, 2019 09:45
@MaciejBaj
Copy link
Contributor

This PR will depend on the outcome of #2937 as well as #3036

I am closing it for now.

@MaciejBaj MaciejBaj closed this Mar 13, 2019
@shuse2 shuse2 deleted the 2940-validation-system-component branch April 3, 2019 06:59
@Matthelonianxl Matthelonianxl mentioned this pull request Jan 9, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nazarhussain nazarhussain Awaiting requested review from nazarhussain

Assignees
No one assigned
Labels
status: invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michielmulders @MaciejBaj @karmacoma @nazarhussain