This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 454
Add validation config for system component - Closes #2940 #2987
Closed
michielmulders
wants to merge
40
commits into
2577-modular-configuration
from
2940-validation-system-component
Closed
Add validation config for system component - Closes #2940 #2987
michielmulders
wants to merge
40
commits into
2577-modular-configuration
from
2940-validation-system-component
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
force-pushed
the
2577-modular-configuration
branch
5 times, most recently
from
February 27, 2019 20:04
a61704e
to
852449e
Compare
nazarhussain
force-pushed
the
2577-modular-configuration
branch
2 times, most recently
from
February 28, 2019 09:45
59a488c
to
af33f72
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
No validation present for system component.
Need one without defaults.
How did I fix it?
Added JSON schema validation.
How to test it?
Run application.
Review checklist