Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create developer guide for React components - Closes #1626 #1965

Merged
merged 6 commits into from
Apr 30, 2019

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Apr 29, 2019

What issue have I solved?

#1626

How have I implemented/fixed it?

I created the guide to describe what we agreed on in technical meetings

How has this been tested?

Open the guide and read it 😉

Review checklist

Copy link
Contributor

@massao massao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@osvaldovega osvaldovega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎perfect

Copy link
Contributor

@michaeltomasik michaeltomasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@slaweet slaweet merged commit 1dd1445 into development Apr 30, 2019
@slaweet slaweet added the ready label Apr 30, 2019
@slaweet slaweet deleted the 1626-improve-guides branch May 8, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants