E2E network management #5345
Merged
E2E network management #5345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e hook when we can initialize the application with customNode
oskarleonard
requested review from
eniolam1000752,
ManuGowda and
ikem-legend
eniolam1000752
suggested changes
Sep 28, 2023
ikem-legend
reviewed
Sep 29, 2023
ikem-legend
reviewed
Oct 4, 2023
…desktop into 5083-e2e-network-management
ikem-legend
approved these changes
Oct 4, 2023
ManuGowda
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5083
How was it solved?
Added E2E tests for
Also removed unnecessary logic in before hook since we now can use a stable local network (customNode) when running the tests in jenkins.
How was it tested?
DEFAULT_NETWORK=customNode yarn devPW_BASE_URL=http://localhost:8080/# yarn run cucumber:playwright:open