-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow mainchain to switch to different service url #5391
Merged
eniolam1000752
merged 14 commits into
release/3.0.0
from
5357-allow-mainchain-to-switch-to-different-service-url
Oct 31, 2023
Merged
Allow mainchain to switch to different service url #5391
eniolam1000752
merged 14 commits into
release/3.0.0
from
5357-allow-mainchain-to-switch-to-different-service-url
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifferent-service-url
…ifferent-service-url
…ifferent-service-url
ikem-legend
previously approved these changes
Oct 30, 2023
ikem-legend
previously approved these changes
Oct 31, 2023
…ifferent-service-url
ikem-legend
approved these changes
Oct 31, 2023
eniolam1000752
approved these changes
Oct 31, 2023
eniolam1000752
deleted the
5357-allow-mainchain-to-switch-to-different-service-url
branch
October 31, 2023 16:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5357
How was it solved?
How was it tested?
Prerequisite
You need to modify the endpoint returning serviceURLs, this we can do by modifying the response in docker, replace serviceURLs with:
The first item in that array should have a http that crashes.
Please refer to the below video.
Screen.Recording.2023-10-27.at.11.41.39.mov
Test the scenarios in "How was it solved?"