Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zero fee balance issue #5459

Merged
merged 16 commits into from
Nov 17, 2023
Merged

Fix zero fee balance issue #5459

merged 16 commits into from
Nov 17, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Nov 16, 2023 •
edited
Loading

What was the problem?

This PR resolves #5445

How was it solved?

  • Implement a hook to validate fee balance
  • Apply hook to all transaction use case
  • Write unit tests

How was it tested?

@eniolam1000752 eniolam1000752 self-assigned this Nov 16, 2023
@eniolam1000752 eniolam1000752 marked this pull request as draft November 16, 2023 14:59
@eniolam1000752 eniolam1000752 marked this pull request as ready for review November 16, 2023 16:12
@ManuGowda ManuGowda requested review from ManuGowda and removed request for ikem-legend November 17, 2023 08:31
oskarleonard
oskarleonard previously approved these changes Nov 17, 2023
View reviewed changes
ManuGowda
ManuGowda reviewed Nov 17, 2023
View reviewed changes
src/modules/common/constants.js Outdated Show resolved Hide resolved
src/locales/en/common.json Outdated Show resolved Hide resolved
eniolam1000752
eniolam1000752 commented Nov 17, 2023
View reviewed changes
src/locales/en/common.json Outdated Show resolved Hide resolved
src/locales/en/common.json Outdated Show resolved Hide resolved
@ManuGowda ManuGowda merged commit 6d9b571 into release/3.0.0 Nov 17, 2023
6 checks passed
@ManuGowda ManuGowda deleted the 5443-fix-fee-issue branch November 17, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarleonard oskarleonard oskarleonard approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@eniolam1000752 eniolam1000752

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eniolam1000752 @ManuGowda @oskarleonard