Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet connect improvements #5474

Merged
merged 20 commits into from
Nov 22, 2023
Merged

Wallet connect improvements #5474

merged 20 commits into from
Nov 22, 2023

Conversation

oskarleonard
Copy link
Contributor

@oskarleonard oskarleonard commented Nov 20, 2023 •
edited
Loading

What was the problem?

This PR resolves #5469 #5468 #5470

How was it solved?

Changed flow of wallet connect responses

How was it tested?

Notify on success

  1. Initiate transaction from wallet connect
  2. enter correct password
  3. Expected: Wallet connect should receive response

Notify on cancel

  1. Initiate transaction from wallet connect
  2. Click cancel
  3. Expected: Wallet connect should receive response
Allow requestView modal to receive new wallet connect requests
  1. Initiate transaction from wallet connect
  2. enter correct password
  3. Initiate another transaction from wallet connect
  4. Expected: New request should be seen in desktop wallet

@oskarleonard oskarleonard marked this pull request as draft November 20, 2023 15:54
@oskarleonard oskarleonard marked this pull request as ready for review November 21, 2023 11:36
@ManuGowda ManuGowda changed the title 5469 walletconnect improvements Wallet connect improvements Nov 21, 2023
@ManuGowda ManuGowda requested review from ManuGowda and removed request for ikem-legend November 21, 2023 17:05
ManuGowda
ManuGowda reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-11-22 at 8 50 37 AM

Now that we changed from signature to full transaction we should updated the text?

@oskarleonard oskarleonard removed the request for review from eniolam1000752 November 22, 2023 15:43
@oskarleonard oskarleonard merged commit 711c326 into release/3.0.0 Nov 22, 2023
6 checks passed
@ManuGowda ManuGowda deleted the 5469-walletconnect-improvements branch November 22, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eniolam1000752 eniolam1000752 eniolam1000752 approved these changes

@ikem-legend ikem-legend ikem-legend approved these changes

@ManuGowda ManuGowda ManuGowda approved these changes

Assignees

@oskarleonard oskarleonard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oskarleonard @ManuGowda @ikem-legend @eniolam1000752