Add get minimal peers list data for discovery process - Closes #3948

[diego-G]

What was the problem?

Discovery process was handling a lot unneeded information which also could make us prone to attacks.

How did I solve it?

Create a new method only used in discovery process. Peers are able to send back peer lists and minimal peer list.

How to manually test it?

npm run test:integration

Review checklist

• The PR resolves Only send back the port and ip when peer requests our peer list #3948
• All new code is covered with unit tests
• Relevant integration / functional tests are added
• Commit messages follow the commit guidelines
• Documentation has been added/updated

[pablitovicente]

Other than the variable name comment seems good but functional WS tets are failing.

[pablitovicente]

Functional WS tests failing for blocksCommon with error

TypeError: Cannot read property 'message' of undefined at Context.it.only (test/mocha/functional/ws/transport/transport.js:243:26) at process._tickCallback (internal/process/next_tick.js:68:7)

Before it was expecting err.response.message but now the same message could be found in err.message though before updating simply the access path to the value we should check if we don't affect other components with this change.

[ishantiw]

Just a few minor comments

[ishantiw]

Thanks 👍

[pablitovicente]

Maybe it's the branch for P2P but functional:WS are still failing as the RPC is failing differently now (returns an error instead of an error wrapped in a response) so I would recommend to create an issue to fix those tests in a different PR but for this release. (btw this tests do pass in 2.2 for example)