Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Don't recreate iframes #144

Closed
Inrego opened this issue Aug 10, 2021 · 6 comments
Closed

[FEATURE_REQUEST] Don't recreate iframes #144

Inrego opened this issue Aug 10, 2021 · 6 comments
Assignees
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@Inrego
Copy link

Inrego commented Aug 10, 2021

When doing work between multiple multiple webapps, it's nice to be able to switch between the different "tabs" in workspace view.
However when doing so, the page gets reloaded back to the original url. It kind of kills my productivity as I can't just switch between tab items.
I came from Organizr, which keeps each tab active (with an option for each item if it should be preloaded right away when loading organizr).

I'm trying to find a replacement for Organizr, and I've come across Dashy and DashMachine which have iframes.
Unfortunately both do this reload, which isn't viable with how I work with my dashboard.

@Inrego Inrego added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Aug 10, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Aug 10, 2021

Good idea, I was actually meaning to do something similar- it would be awesome if you want to submit a PR, let me know if you need any help :) Or I can work on it this weekend, it should be a quick task.

@Lissy93
Copy link
Owner

Lissy93 commented Aug 11, 2021

Hiya @Inrego How's it going?
So I was looking into this yesterday, and there are some performance implementations of keeping apps open in the background, it has quite a big impact on speed, so I think this should be an optional feature that can be enabled by the user, rather than something that is enabled by default. One of the primary aims of Dashy is speed, I want to try and keep it as fast as possible, so that it can be used as a landing page.

@Lissy93
Copy link
Owner

Lissy93 commented Aug 11, 2021

Okay, I've implemented this in #146 which, when merged will be released in V 1.5.8.
Here's a quick demo:
Screen recording of multi-tasking

So keeping apps open in the background has an impact on performance, and therefore this is an optional feature. You can enable it by setting appConfig.enableMultiTasking: true.
Note that the first time an app is opened, it will still need to load, this is similar to opening apps in browser tabs.

Hope that helps :)

@Inrego
Copy link
Author

Inrego commented Aug 11, 2021

That looks like exactly what I was looking for. I was also thinking it should've been an option, since it's a change of previous behavior, which some might prefer.

Actually, i was even thinking it could be an option per tab, in case some tabs are more suitable for being reloaded every time, although it's not at all a feature I'd need. This is definitely enough for me to move on from organizr i think.

@ExXxtr3me
Copy link

Great Feature!!! Would it be possible to add this also to the modal view?

@Lissy93
Copy link
Owner

Lissy93 commented Aug 12, 2021

This is a good idea, it would be useful for modals to be able to be switched between.
It's slightly trickier to implement though, as IframeModal.vue gets destroyed everytime it is minimized. I guess the solution would be for me to write my own simple modal so that I can control the lifecycle of it, and keep it open in the background.

I'll add this to my future todo list, and update you hear if/ when it gets implemented, but I don't think it will be very soon, given the changes that would need to be made. Alternativley, either of you are welcome to submit a PR with this feature. If you do, make it optional and only enabled when appConfig.enableMultiTasking: true so that it doesn't affect existing users or default performance.

asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Closes Lissy93#144

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Development

No branches or pull requests

3 participants