-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Configuration cannot be saved when using tags #430
Comments
This comment has been minimized.
This comment has been minimized.
I think you need to put a space after each tag, because the editor splits it into an array. But I will take a look at it, thanks for raising. |
That is correct. But when I open an existing item with multiple tags it is displayed without space to change it. |
I've been trying to recreate this, but with no luck. Did you get an error message? Did this error prevent you from saving the item? |
Sorry, no error-messages. I create an new item with and without spaces, SAVE-Button works: Then edit again the same entry: Only when I add spaces after the commas or delete the TAGS entry complete, I can use again the SAVE-Button. By the way: As you can see it seems that numbers are removed from tags. best regards, |
The numbers being removed from the tags does indeed seem to be a bug, I will get that fixed. But the spacing is not a bug, it's just how arrays work in JavaScript. |
OK. But it's a bit annoying to insert the blanks again on every change. At the beginning I was also confused because I could not understand why the saving does'nt work. But it's OK, I can handle it now. Thanks for your work! |
If saving isn't working, then that does sound like a bug, but I've not been able to recreate. Did you see any error in the console? |
The fix for this issue has now been released in Dashy 2.0.0 ✨ If you haven't done so already, please update your instance to Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project. |
Environment
Self-Hosted (Docker)
Version
1.9.8
Describe the problem
If you use more than one indicator, the SAVE-Button of the Interactive Editor doesn't work.
I have to put a blank after the comma then it works again.
The behavior occurs only when changing items.
The blank character is not needed when creating new items.
Tags aaa → works
Tags aaa,bbb → SAVE-Button doesn't work
Tags aaa, bbb → works
Additional info
No response
Please tick the boxes
The text was updated successfully, but these errors were encountered: