Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Configuration cannot be saved when using tags #430

Closed
4 tasks done
RK62 opened this issue Jan 21, 2022 · 11 comments
Closed
4 tasks done

[BUG] Configuration cannot be saved when using tags #430

RK62 opened this issue Jan 21, 2022 · 11 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.0.0

Comments

@RK62
Copy link

RK62 commented Jan 21, 2022

Environment

Self-Hosted (Docker)

Version

1.9.8

Describe the problem

If you use more than one indicator, the SAVE-Button of the Interactive Editor doesn't work.
I have to put a blank after the comma then it works again.
The behavior occurs only when changing items.
The blank character is not needed when creating new items.

Tags aaa → works
Tags aaa,bbb → SAVE-Button doesn't work
Tags aaa, bbb → works

Additional info

No response

Please tick the boxes

@RK62 RK62 added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Jan 21, 2022
@liss-bot

This comment has been minimized.

@Lissy93
Copy link
Owner

Lissy93 commented Jan 21, 2022

I think you need to put a space after each tag, because the editor splits it into an array. But I will take a look at it, thanks for raising.

@RK62
Copy link
Author

RK62 commented Jan 21, 2022

image

image

@Lissy93 Lissy93 reopened this Jan 21, 2022
Repository owner deleted a comment from liss-bot Jan 21, 2022
@RK62
Copy link
Author

RK62 commented Jan 21, 2022

That is correct. But when I open an existing item with multiple tags it is displayed without space to change it.
Not important, I was just wondering why the save didn't work.

@Lissy93
Copy link
Owner

Lissy93 commented Jan 26, 2022

I've been trying to recreate this, but with no luck. Did you get an error message? Did this error prevent you from saving the item?

@RK62
Copy link
Author

RK62 commented Jan 27, 2022

Sorry, no error-messages.

I create an new item with and without spaces, SAVE-Button works:

image

Then edit again the same entry:
SAVE Buttons light white, but no reaction or message on click, the window will stay open.

image

Only when I add spaces after the commas or delete the TAGS entry complete, I can use again the SAVE-Button.
I'm using the actual version of the Windows-EDGE Browser.

By the way: As you can see it seems that numbers are removed from tags.

best regards,
Ralf

@Lissy93
Copy link
Owner

Lissy93 commented Jan 28, 2022

The numbers being removed from the tags does indeed seem to be a bug, I will get that fixed.

But the spacing is not a bug, it's just how arrays work in JavaScript.

@RK62
Copy link
Author

RK62 commented Jan 28, 2022

OK. But it's a bit annoying to insert the blanks again on every change. At the beginning I was also confused because I could not understand why the saving does'nt work. But it's OK, I can handle it now. Thanks for your work!

@Lissy93
Copy link
Owner

Lissy93 commented Jan 28, 2022

If saving isn't working, then that does sound like a bug, but I've not been able to recreate. Did you see any error in the console?

@RK62
Copy link
Author

RK62 commented Jan 30, 2022

Is this perhaps a problem with the Docker container?
Let me try to explain it again more clearly.

  1. I create a new docker container with compose
version: "3.8"
services:
  z-dashy:
    image:            lissy93/dashy:release-1.9.9
    container_name:   z-dashy
    hostname:         z-dashy
    ports:
      - 8012:80
  1. I create a new section and a new item. For the item I assign additional 2 tags
    image

  2. I change the item afterwards and it can't be saved. When I click on SAVE nothing happens, the edit window remains open. Only when I delete the tags or add a space between the 2 tags I can save the changed entry sucsessfully.
    image

There are no messages on the console of the DASHY container but I get this message in the EDGE console:
image

Hope it helps...

@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in Dashy 2.0.0 ✨

If you haven't done so already, please update your instance to 2.0.0 or later. See Dashy 2.0.0 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.0.0
Projects
None yet
Development

No branches or pull requests

3 participants