Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Section still visible while searching, even when no results #447

Closed
Lissy93 opened this issue Jan 26, 2022 Discussed in #444 · 3 comments
Closed

[BUG] Section still visible while searching, even when no results #447

Lissy93 opened this issue Jan 26, 2022 Discussed in #444 · 3 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.0.0

Comments

@Lissy93
Copy link
Owner

Lissy93 commented Jan 26, 2022

Raised by @kimpenhaus in #444

Originally posted by kimpenhaus January 25, 2022
Hi,

there seems to be a change lately which shows a 'no items to show yet' label in empty, expanded container with no elements. Before those container were hidden - is there any config prop to enable the old behavior again?

Thanks,
m.

image

Probably Cause

The no-results class is being correctly applied

dashy/src/views/Home.vue

Lines 45 to 46 in 5f8a83f

:class="
(searchValue && filterTiles(section.items, searchValue).length === 0) ? 'no-results' : ''"

But the CSS that hides the section doesn't seem to have any effect:

dashy/src/views/Home.vue

Lines 262 to 263 in 5f8a83f

/* Hide when search term returns nothing */
.no-results { display: none; }

@Lissy93 Lissy93 added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Jan 26, 2022
@Lissy93 Lissy93 self-assigned this Jan 26, 2022
@kimpenhaus
Copy link

Thank you!

@kimpenhaus
Copy link

kimpenhaus commented Jan 29, 2022

Looks to be good with the latest docker version! Thanks for the quick fix!

@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in Dashy 2.0.0 ✨

If you haven't done so already, please update your instance to 2.0.0 or later. See Dashy 2.0.0 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working 🔨 Fixed 🛩️ Released 2.0.0
Projects
None yet
Development

No branches or pull requests

3 participants