Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add option for image in header, Re: #104 #105

Merged
merged 6 commits into from
Jul 26, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jul 26, 2021

Category: Feature

Overview: Adds an optional attribute, pageInfo.logo, enabling the user to display a logo image in the apps header.

Issue Number #104

New Vars

  • pageInfo.logo - string - Optional
    • The path to an image to display in the header (to the right of the title). This can be either local, where / is the root of ./public, or any remote image, such as https://i.ibb.co/yhbt6CY/dashy.png. It's recommended to scale your image down, so that it doesn't impact load times

Screenshot
Link

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Jul 26, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 91ededa

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60ff1621cb79f400073160ed

😎 Browse the preview: https://deploy-preview-105--dashy-dev.netlify.app/

@Lissy93 Lissy93 merged commit 8ae65e9 into master Jul 26, 2021
@Lissy93
Copy link
Owner Author

Lissy93 commented Jul 26, 2021

Merged 🔀
This feature was suggested by @Docrom in #104.
Adds support for optional custom image in header.
To use, set pageInfo.logo to the path of image.
You must be useing Dashy V 1.4.5 of later.

@Lissy93 Lissy93 deleted the FEATURE/104_add-image-to-header branch July 26, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant