Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve background image resize #1058

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Solve background image resize #1058

merged 2 commits into from
Jan 29, 2023

Conversation

BySempron
Copy link
Contributor

@BySempron BySempron commented Jan 10, 2023

BySempron Quick BySempron /master → Lissy93/dashy Commits: 2 | Files Changed: 2 | Additions: 0 Label

Category: Bugfix

Overview

Fix #984

When open and closing sections, the background image resize. Added a couple of CSS keys to keep the image full screen and static.

Issue Number #984

Screenshot

Animation.webm

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Jan 10, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit c7c4df7
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63d512b4e8bb6b0009a6c474
😎 Deploy Preview https://deploy-preview-1058--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 10, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Lissy93 Lissy93 merged commit 7080e3c into Lissy93:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Image background moves when open/close section
2 participants