Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Pi-Hole widgets adding authentication #1074

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Conversation

albcp
Copy link
Contributor

@albcp albcp commented Jan 20, 2023

albcp Medium albcp /master → Lissy93/dashy Commits: 2 | Files Changed: 3 | Additions: 18 Label Unchecked Tasks

Category: Bugfix

Overview

  • Added authentication to PiHoleStats and PiHoleTraffic widgets as required since Pi-hole Web v5.18
  • Updated widget documentation

Fix #1018

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@albcp albcp requested a review from Lissy93 as a code owner January 20, 2023 21:26
@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit c867a90
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63cb071256164c000833087b
😎 Deploy Preview https://deploy-preview-1074--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 20, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @albcp - this looks great 🙌

Just to clarify - does the Pi Hole API now always require auth to fetch this data? Last time I used it, auth was only required to get full results, fetch anything showing private info, to make changes, or if the user has configured it. But I was surprised about that, so expected it to change sometime.

(I've switched to AdGuard, so will need to spin up a pihole instance to properly confirm that)

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes - it appears that it has changed 👍

@Lissy93 Lissy93 merged commit 4a5024c into Lissy93:master Jan 21, 2023
yeochinyi pushed a commit to yeochinyi/dashy that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Pi-Hole widgets need Auth API after last update
2 participants