Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 bump version: update-authors GitHub action #1091

Merged
merged 1 commit into from
Feb 4, 2023
Merged

👷 bump version: update-authors GitHub action #1091

merged 1 commit into from
Feb 4, 2023

Conversation

a-mnich
Copy link
Contributor

@a-mnich a-mnich commented Jan 30, 2023

a-mnich Quick a-mnich /FIX/Authors → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label

Category: Bugfix

Overview
The Github Action version of wow-actions/update-authors which is used for generating the AUTHORS file was updated to v1.1.4 in the according workflow.

Bug Description:
The AUTHORS file is broken as the GitHub action (wow-actions/update-authors) generated a faulty file if author names included spaces.
This was fixed with v1.1.4 of this action.

Issue Number: n/a

Code Quality Checklist

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@a-mnich a-mnich requested a review from Lissy93 as a code owner January 30, 2023 19:54
@netlify
Copy link

netlify bot commented Jan 30, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit f17cbc3
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63d8208bc3cd4600086dc1ab
😎 Deploy Preview https://deploy-preview-1091--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 30, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good - thanks :)

@Lissy93 Lissy93 merged commit 2772f8f into Lissy93:master Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants