Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapping incorrect icons #1175

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

gbrown09
Copy link
Contributor

@gbrown09 gbrown09 commented May 4, 2023

gbrown09 Quick gbrown09 /weather-icon-fix → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label Unchecked Tasks Powered by Pull Request Badge

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:
Bugfix

Overview
Just swapping the icons since I was getting night icons during the daytime. Went off of these: https://github.com/isneezy/open-weather-icons/blob/23fbe8a68faa04fa85003d15525d6b1ada746c58/scss/open-weather-icons.scss

Issue Number #747

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@gbrown09 gbrown09 requested a review from Lissy93 as a code owner May 4, 2023 23:59
@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit d22b8de
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/645446ef9e814800081e8cc1
😎 Deploy Preview https://deploy-preview-1175--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented May 5, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gbrown09 :)

@Lissy93 Lissy93 merged commit bc9e193 into Lissy93:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants